Ashinch / ReadYou

An Android RSS reader presented in Material You style.
GNU General Public License v3.0
5.13k stars 202 forks source link

Replace deprecated SwipeRefresh with recomended PullRefreshIndicator and implement pull to refresh for Feeds Page. #850

Closed yajaru closed 1 month ago

yajaru commented 1 month ago

SwipeRefresh library is deprecated (see https://google.github.io/accompanist/swiperefresh/) so this change is to switch over to using the recommended replacement (PullRefreshIndicator and friends) for pull to refresh.

I also implemented pull to refresh on the Feeds page and removed the refresh button there as it is now redundant.

JunkFood02 commented 1 month ago

See #722, maybe we'll need to migrate to androidx.compose.material3.pulltorefresh instead of the md2 one

yajaru commented 1 month ago

Missed that; I'll see about switching over to the new version and updating the PR.

JunkFood02 commented 1 month ago

lgtm, thx!