search

Ashinch / ReadYou

An Android RSS reader presented in Material You style.
GNU General Public License v3.0
5.11k stars 202 forks source link

Improved Adaptive Navigation in RYScaffold #877

Open kdroidFilter opened 1 week ago

kdroidFilter commented 1 week ago

Summary

This PR improves RYScaffold to better handle adaptive navigation

Conditional Bottom Bar: Uses NavigationSuiteScaffold only if navigationSuiteItems are present, avoiding empty bars on mobile.

Adaptive Integration: Updated FilterBar for adaptive behavior based on screen size.

Future Improvement

Consider repositioning the settings button on the home page.

JunkFood02 commented 6 days ago

Do you have any screenshot or screen record for this change?

kdroidFilter commented 5 days ago

image According to material 3 conventions, it is not recommended to use a bottom bar on large screens.

JunkFood02 commented 4 days ago

According to material 3 conventions, it is not recommended to use a bottom bar on large screens.

This's true, but instead of just replacing the component, I'd prefer a redesigned layout for large screens. And your screenshot looks no better than a bottom navigation bar ux wise imo

kdroidFilter commented 4 days ago

Yes I also think that it should not be merged like that, but I thought that it was already a good starting point

JunkFood02 commented 1 day ago

I agree that we should probably make a better navigation for large screens. However, I think the bottom bar here doesn't apply to the guidelines because it's a filter bar, not a navigation bar. It changes the current state of the screen instead of navigating users to another screen