search

Ashinch / ReadYou

An Android RSS reader presented in Material You style.
GNU General Public License v3.0
5.11k stars 202 forks source link

Update strings.xml #887

Closed nvllz closed 1 day ago

nvllz commented 4 days ago

Improved many strings, grammar errors, and tried to make the overall phrasing more consistent.

If you can, please check it for missing escape characters, not sure if everything is correct to merge.

JunkFood02 commented 1 day ago

We're not an enterprise product so i think it's not that crucial to keep a consistent wording throughout the app. And many translations have already been submitted on hosted weblate. If we modify the source strings here, all the translations will be flagged as outdated, requiring our volunteers to retranslate them. To avoid this unnecessary work, I'd suggest that we only correct the strings that are genuinely confusing or unclear, leaving the others untouched

nvllz commented 1 day ago

You spend so much time correcting tonal elevations and would keep bad phrasing? I really appreciate your work and wanted to help you improve the app. I guess the majority of users use English and the weblate thing will be fixed sooner or later. No "unnecessary work" if something can be improved, it's also about your honest work here.

JunkFood02 commented 1 day ago

I couldn't care less about your strong desire to help us improve the app. Coding for the app, collecting user feedbacks, and reviewing pull requests all require time and effort. A large pull request that consists of many changes covering different issues is difficult to review and merge. If you still want to merge the changes in this PR, please break it down to smaller ones, each addressing a single issue like grammar, tone or mismatched descriptions.

nvllz commented 1 day ago

If you still want to merge the changes in this PR, please break it down to smaller ones, each addressing a single issue like grammar, tone or mismatched descriptions.

No idea what's on your mind here, you can comment under lines you don't understand and I'll tell you why I decided to change it. I've already submitted a few strings.xml PRs, which got merged and @Ashinch never said weblate is a problem.

A large pull request that consists of many changes covering different issues is difficult to review and merge

It's just strings, no "other issues" here. Don't make me create 40 Pull Requests describing why "You can tap the account name on the feed page to toggle it" is wrong (since you're not really toggling, as in binary, but selecting another account from a list) just because I pointed out something in your PR. No shaming here, just correcting lines I thought needed improvement. Please consider it once again guys.

JunkFood02 commented 22 hours ago

make me create 40 Pull Requests describing why "You can tap the account name on the feed page to toggle it" is wrong

just do it, and you can include all your grammar fix in a single pr so it doesn't grow to 40

The current UI text does indeed need improvement. Some of these issues can be resolved by simply modifying the strings (such as the grammar issues you mentioned), while others require larger code-level changes to accommodate.