search

AshiqurRah / pe

0 stars 0 forks source link

Unable to change rating of employee #5

Open AshiqurRah opened 1 year ago

AshiqurRah commented 1 year ago

In the event of an accidental typing of a wrong rating to an employee, I am unable to change the rating of the employee completely. I am only able to make a new rating tomorrow

Screenshot 2022-11-11 at 4.54.55 PM.png

nus-pe-bot commented 1 year ago

Team's Response

Same issue regarding the user being unable to change the rating for an employee.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

[Rate] Unrate employee

Even though it is stated in the UG that we are unable to unrate an employee, I believe that it is a feature flaw to not have it as there are many circumstances that may call for such a function.

It is entirely possible that an employer has wrongly rated his employee.

In this situation after using rate id/1 r/5, he may want to reduce his rating to a 4 or a 3. But this is not possible in Coydir.

Another possible situation, is the employer has rated the wrong employee. As such, he would have to delete, the wrongly rated employee, and add him back again.

image.png

[original: nus-cs2103-AY2223S1/pe-interim#2179] [original labels: type.FeatureFlaw severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Hi there! Thanks so much for the report.

We acknowledge that this is a sub-optimal design, however allowing for the editing of employees' ratings was not one of our higher priorities, as our main priority was to finish the rate functionality, and to integrate it with the performance history graph. Additionally, we have explained in the UG that this behaviour is currently not supported, and thus we would like to label this issue as not in scope.

image.png

Once again, thank you so much for informing us regarding the error.

Cheers,
Coydir
HR is hard, Coydir is easy
(est. 2022)

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]