search

AshiqurRah / pe

0 stars 0 forks source link

Duplicate checking is case insensitive #6

Open AshiqurRah opened 1 year ago

AshiqurRah commented 1 year ago

Able to add employees of the same name, job, department and phone number.

Lower cased letters Screenshot 2022-11-11 at 4.56.15 PM.png

Upper cased letters Screenshot 2022-11-11 at 4.57.37 PM.png

nus-pe-bot commented 1 year ago

Team's Response

Same issue regarding handling duplicates with different capitalisation.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

[Add] Duplicate Residents

Steps to reproduce: Command 1: add n/John doe j/Test d/Administration Command 2: add n/John dOe j/Test d/Administration

Expected: Coydir deems the same name with different capitalizations as two different employees.

While it is entirely possible that two employees have the same name, and same role, and same department. Coydir should at least warn the user of such a circumstance, and allow the user the freedom to proceed or not.

Refer to the images below for their name, position, and department.

image.png

image.png

[original: nus-cs2103-AY2223S1/pe-interim#2875] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Hi there! Thanks so much for the report.

We acknowledge this bug. However, we did not to intend handle duplicates in a manner like what you suggested, thus we feel that issue is more of a Feature Flaw rather than a functionality bug.

Once again, thank you so much for informing us regarding the error.

Cheers, Coydir HR is hard, Coydir is easy (est. 2022)

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]