Adding leave in the wrong view

[AshiqurRah]

Though the command works, however it can be misleading for the user as he would have wanted to add the leave to Tom. One suggestion would be to show an error message to go back to list view before.

Steps to reproduce

find n/Tom

add-leave id/1 sd/01-01-2022 ed/01-01-2022

Screenshot:

[nus-pe-bot]

Team's Response

Hi there! Thanks so much for the report.

For the add-leave command, the main parameter it takes in is employee ID, not index, which is mentioned in the error message, the help window, and in the UG. As such, there is no reason for the app to provide an error message as you suggested, or to impede the user from adding a leave period to an employee who is not being displayed in the Person List Panel on the left.

Hence, we disagree with your issue and your suggestion, and will reject this bug.

Once again, thank you so much for informing us regarding the error.

Cheers,
Coydir
HR is hard, Coydir is easy
(est. 2022)

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

• [x] I disagree

Reason for disagreement: The bug that I have mentioned above is targetted on the fact that the add-leave command should have only executed in the full list page and not in the filtered list. I have labelled this severity as severity.Low as it is a flaw that is unlikely to affect normal operations of the product. Appears only in very rare situations, when the users misinterpret the id as the index shown in the filtered list, and this causes a minor inconvenience, which is the adding of leave to the wrong person.

As such, the add-leave should have been restricted in the filtered list and return an error message

---