AshishJoshi-asj / zfdatagrid

Automatically exported from code.google.com/p/zfdatagrid
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

searchType should be available in Filter options as well #158

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
"searchType" is available as an option in updateColumn, but not in addFilter.
Maybe it would be good to have it on both places. First for default
filters, and the other when defining a special filter

What version of the product are you using? On what operating system?
0.6alpha

Please provide any additional information below.
If defining columns and filters on different places in file, or in
different files, it is not easy to check info on two places.

Original issue reported on code.google.com by vlatko.b...@gmail.com on 13 Feb 2010 at 9:45

GoogleCodeExporter commented 9 years ago
Hi,

The problem is really about defining the same option on different places.

I will consider pass this options 

# orderField =>filterField
# searchType =>filterType
# searchTypeFixed => filterTypeFixed
# search => filter

to Bvb_Grid_Filters

______________________________________________
Best Regards,
Bento Vilas Boas

Original comment by pao.fre...@gmail.com on 13 Feb 2010 at 2:56

GoogleCodeExporter commented 9 years ago
Or renaming Bvb_Grid_Filters to Bvb_Grid_Search

# orderField =>searchField
# searchType 
# searchTypeFixed
# search

To be continued... :)

Original comment by pao.fre...@gmail.com on 13 Feb 2010 at 2:58

GoogleCodeExporter commented 9 years ago
Hm, about renaming. I think you named them very well. They really do the 
Filtering.

I was thinking about simply overwriting Column searchType with Filter 
searchType. The
programmers responsibility would be to decide which one suites best.

For default filters, Column searchType is better. No need for Filters at all.
However, for custom Filters, much easier would be to set searchType in Filter.
Especially with new coming filter callback functions. :-)

I'm not sure I understood correctly all of the above. Are you planning to have
separate search and filter types?

Original comment by vlatko.b...@gmail.com on 13 Feb 2010 at 4:00

GoogleCodeExporter commented 9 years ago
"I'm not sure I understood correctly all of the above. Are you planning to have
separate search and filter types?
"

No. I was just wondering which names is better. Search or Filter. :)

Best Regards,
Bento Vilas Boas

Original comment by pao.fre...@gmail.com on 13 Feb 2010 at 4:17

GoogleCodeExporter commented 9 years ago
Hi,

searchType also as option for Bvb_Grid_Filters

Update to revision 581

Best Regards,
Bento Vilas Boas

Original comment by pao.fre...@gmail.com on 13 Feb 2010 at 4:24

GoogleCodeExporter commented 9 years ago

Original comment by pao.fre...@gmail.com on 14 Feb 2010 at 3:41

GoogleCodeExporter commented 9 years ago
Verified

Original comment by vlatko.b...@gmail.com on 16 Feb 2010 at 11:59

GoogleCodeExporter commented 9 years ago

Original comment by bento.vi...@gmail.com on 3 Mar 2010 at 4:56