AshleyYakeley / NixVirt

LibVirt domain management for Nix
MIT License
193 stars 21 forks source link

[Feedback] Regarding testing of new features #21

Closed Libadoxon closed 7 months ago

Libadoxon commented 7 months ago

I'm really enjoying the project but there are still many options missing regarding the XML files. That is not a problem in its self as I have no problem with patching those in myself and opening pull request but I'm unsure how to implement testing for those new features. In my last pull request I created a new test but I don't think that that would be feasible to do for each new element. Alternative I could create one test and gradually update them or maybe don't write a test at all? That's what I would like your feedback on, so I don't trash the repository while still ensuring correct translation from nix to XML.

AshleyYakeley commented 7 months ago

If you're just updating files in generate-xml/ by adding more elements and attributes in the same way as the existing code, then you don't need to add new tests.

If you're doing something new or modifying generate-xml/generate.nix or generate-xml/xml.nix, etc., then you should make sure that is covered one way or another.

Libadoxon commented 7 months ago

Thanks for the clarification