search

AshtonKem / Butler

Jenkins/Hudson plugin for Emacs
44 stars 10 forks source link

Packaging issues #5

Closed purcell closed 10 years ago

purcell commented 11 years ago

Hi! I've added a butler recipe to MELPA so that we can automatically build packages of it.

There are currently a couple of issues with butler.el, so I thought I'd just bring them to your attention:

Firstly, the Package-Requires header should include (json "1.2"), since that library is not a standard Emacs library, but it is required by butler.el.

Secondly, although you've declared lexical-binding on the first line, it looks like you're not using it, since the lexical-let* macro you're using accomplishes the same thing without requiring lexical-binding.

If you need to keep the lexical-binding: t setting, then you should add (emacs "24") to the Package-Requires header, because your code won't work as expected in Emacs 23. If you don't need the lexical-binding setting - which would be ideal - then you should remove it.

In order to byte-compile cleanly, your use of lexical-let* suggests you should have a

(eval-when-compile (require 'cl))

Finally, you should probably add an autoload declaration for butler-status:

;;;###autoload
(defun butler-status (...) ...)

This way, when users have installed the package, they will not need to explicitly require it before using M-x butler-status.

Hope that feedback helps! :-)

-Steve

AshtonKem commented 10 years ago

Thanks Steve! I'll work on adding that in.

milkypostman commented 10 years ago

@AshtonKem seems to be another build problem with some recent changes. namely that you list deferred as a dependency but you don't specify a version. seems like (package-buffer-info) doesn't like that so it's breaking the build of the package. as far as melpa is concerned the version really doesn't matter but you should go ahead and just put the lowest stable version for a package that you know has the goodies you need.

AshtonKem commented 10 years ago

Awesome, I'll give that a try. Thanks!

--Ashton

Sent from my iPhone

On Dec 21, 2013, at 1:02 AM, Donald Ephraim Curtis notifications@github.com wrote:

@AshtonKem seems to be another build problem with some recent changes. namely that you list deferred as a dependency but you don't specify a version. seems like (package-buffer-info) doesn't like that so it's breaking the build of the package. as far as melpa is concerned the version really doesn't matter but you should go ahead and just put the lowest stable version for a package that you know has the goodies you need.

— Reply to this email directly or view it on GitHub.

purcell commented 10 years ago

Thanks for fixing this up. :-)