search

Ashutosh00710 / github-readme-activity-graph

A dynamically generated activity graph to show your GitHub activities of last 31 days.
https://ashutosh00710.github.io/github-readme-activity-graph
MIT License
1.67k stars 685 forks source link

BUG: No zero index on Y axis #144

Closed jgphilpott closed 2 years ago

jgphilpott commented 2 years ago

Describe the Bug

The Y axis scale should always start at 0 even if the lowest activity day is > zero.

To Reproduce

See screenshot.

Expected behavior

Even though the lowest activity day is 1 the Y axis scale should start from zero.

Screenshots

Screen Shot 2022-09-21 at 9 48 47 AM
Ashutosh00710 commented 2 years ago

Graph is looking fine to me image

jgphilpott commented 2 years ago

That's because I haven't made any commits yet today so there is a zero activity day. Once I have a commit you will see it change again. ... there must be something in the code scaling the graph between the highest value and the lowest value but it should scale between the highest value and zero.

jgphilpott commented 2 years ago

See the same day after adding 1 commit:

Screen Shot 2022-09-22 at 7 33 16 PM
jgphilpott commented 2 years ago

I just opened a pull request. Look at the difference between the main deployment and my personal deployment that includes the fix.

Main Deployment

Screen Shot 2022-09-23 at 10 54 33 AM

Personal Deployment

Screen Shot 2022-09-23 at 10 54 45 AM
Ashutosh00710 commented 2 years ago

That's because I haven't made any commits yet today so there is a zero activity day. Once I have a commit you will see it change again. ... there must be something in the code scaling the graph between the highest value and the lowest value but it should scale between the highest value and zero.

Got you

Ashutosh00710 commented 2 years ago

145 closes this issue