Implemented height option to allow consumers to change the height of the chart

Ashutosh00710 / github-readme-activity-graph

A dynamically generated activity graph to show your GitHub activities of last 31 days.

https://ashutosh00710.github.io/github-readme-activity-graph

MIT License

1.67k stars 685 forks source link

Implemented height option to allow consumers to change the height of the chart #186

Closed jmloudis closed 1 year ago

jmloudis commented 1 year ago

All Submissions

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions

[x] Does your submission pass tests?
[ ] Have you lint your code locally prior to submission?

Changes to Core Features

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your core changes, as applicable?
[x] Have you successfully ran tests with your changes locally?

jmloudis commented 1 year ago

https://github.com/jmloudis/github-readme-activity-graph/commit/45c9ff26bc9ab2e03a33c10d6741c54098e5f3e2#commitcomment-101172123

https://github.com/jmloudis/github-readme-activity-graph/commit/ac2a95d818bc9ee62435e7b4db5e987003a540a9#commitcomment-101173703

jmloudis commented 1 year ago

Hey team,

Would you be able to review the changes and let me know what you think. I believe I followed the submission guides. Thanks!

Ashutosh00710 commented 1 year ago

Hi @jmloudis, thank you for your contribution, changes are looking good to me but before merging it to main can you please share some screenshots of different heights??

jmloudis commented 1 year ago

Hey @Ashutosh00710,

Yes of course. I left a link to the comment above but I can copy the message with the screenshots. Here you go.

Implemented height query option for chart instead of having a hard coded value. The consumer can query any height value in between the range [200,600]. Any value outside of the range will revert to the max / min value of either 200 or 600. If no height option is configured, the default value of 420 will be displayed.

Default height: 420

Smallest height: 200

Largest height: 600

jmloudis commented 1 year ago

Will do! I will work on that and create another commit when I get home from work tonight.

jmloudis commented 1 year ago

Hey @Ashutosh00710, Just updated the README.md to include the height parameter. Wasn't sure if I should add myself to the contributors list or If I missed anything else. Let me know if I need to add anything else!

Ashutosh00710 commented 1 year ago

Thanks for the modifications @jmloudis. You can add your name to the contributors list and create a new PR mentioning the PR hash.