Issue #191 resolved and vercel.json deployment script added

mdmuhtasimfuadfahim commented 1 year ago

All Submissions

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions

[x] Does your submission pass tests?
[x] Have you lint your code locally prior to submission?

Changes to Core Features

[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your core changes, as applicable?
[ ] Have you successfully ran tests with your changes locally?

Ashutosh00710 commented 1 year ago

Hi @mdmuhtasimfuadfahim, thank you for your pull request. I have reviewed your PR and unfortunately, it seems that the vercel.json file you provided is not functioning as expected. The current implementation just redirects the project back to my repository. However, there is another PR (#195) that addresses this issue and provides the correct implementation of the vercel.json file. Therefore, I have to close this PR with this comment. Thank you for your contribution!

mdmuhtasimfuadfahim commented 1 year ago

Thanks for your feedback and I appreciate it. i thought the issue was only witg the vercel app deployments and a vercel.json can solve that problem. That's why I added that with the redirect link. I would like to contribute in future too if possible and hope we will work together in the future.

Thank you.

On Sat, 29 Apr 2023, 8:25 pm Ashutosh Dwivedi, @.***> wrote:

Hi @mdmuhtasimfuadfahim https://github.com/mdmuhtasimfuadfahim, thank you for your pull request. I have reviewed your PR and unfortunately, it seems that the vercel.json file you provided is not functioning as expected. The current implementation just redirects the project back to my repository. However, there is another PR (#195 https://github.com/Ashutosh00710/github-readme-activity-graph/pull/195) that addresses this issue and provides the correct implementation of the vercel.json file. Therefore, I have to close this PR with this comment. Thank you for your contribution!

— Reply to this email directly, view it on GitHub https://github.com/Ashutosh00710/github-readme-activity-graph/pull/194#issuecomment-1528800697, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQRFBCCKB57VPCKDY2WCKMTXDUQFFANCNFSM6AAAAAAXNMK7EY . You are receiving this because you were mentioned.Message ID: @.*** com>

Ashutosh00710 / github-readme-activity-graph