search

Ashwatthaamaa / Neuwaita

A neumorphic take on adwaita theme
Creative Commons Zero v1.0 Universal
54 stars 2 forks source link

Symlink icons #5

Closed TheEvilSkeleton closed 2 years ago

TheEvilSkeleton commented 2 years ago

This MR symlinks icons instead of copy pasting them. This helps avoiding the need of duplicating icons (and thus duplicating size too). Here are all the changes:

A little tip: you can run the following commands from the terminal to symlink:

cd PATH/TO/DIR
ln -s SOURCE.svg DESTINATION.svg
Ashwatthaamaa commented 2 years ago

so should we have a system as to which should be primary icon? like for instance if there is flatpak then we will name by that name if not then snaps or something and so on ?

TheEvilSkeleton commented 2 years ago

This is up to you, but I prefer everything with reverse-dns. It was cocky of me to move everything to reverse-dns without any discussion, so I want to apologize for that. My goal was to have a standard so we can easily reference the source icons by using reverse-dns instead of fiddling around. If you prefer something else, I will gladly change it.

And yes, it's like that. Many desktop entries like Firefox's specify different icon names, which can cause tons of problems with compatibility. In Firefox's case, Firefox from Flathub uses Icon=org.mozilla.firefox. Firefox from system package managers uses Icon=firefox in the desktop entry. So I symlinked org.mozilla.firefox.svg to firefox.svg to make these desktop entries compatible for both cases. Without the symlink, if I was to use Firefox from my distro repos, which comes with a desktop entry containing Icon=firefox, then the icon theme wouldn't apply the Firefox icon. With the symlink, it does. The same goes with many of the symlinks I have done in this MR.

I symlinked many of these icons to maximize compatibility. For example, org.mozilla.firefox symlinks to org.mozilla.Firefox, because the former is used by Flathub, but the latter is used by Fedora Flatpaks. Even a casing distinction can cause issues.

Ashwatthaamaa commented 2 years ago

@TheEvilSkeleton yea this is good. Actuallly I was thinking of doing something along the same line with flatpaks names as primary as it is easy names for me to find than distro specific names. so yea lets do reverse-DNS as primary icons and symlink to others.

Also lets make a list of icons that are common and add new icon requests to that thread.