Ashwinning / libmv

Automatically exported from code.google.com/p/libmv
MIT License
0 stars 0 forks source link

Reg: autocalibration.cc - Correction #32

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
Reference: 
    Path: libmv\src\libmv\multiview\autocalibration.cc
    Lines: 105 to 109 (see below)

  // Eigen values should be possitive,
  Vec temp_values = eigen_solver.eigenvalues();
  if (temp_values.sum() < 0) {
    temp_values = -temp_values;
  }

After execution of these lines, I am still finding negative eigen values in 
temp_values.

What is the expected output? What do you see instead?
If I am not wrong, this should code should replaced with the code given below 
to ensure non-negative eigen values:

    for( int i = 0; i < 4; i++)
    {
        if(temp_values[i] < 0){
            temp_values[i] = -temp_values[i];
        }        
    }

What version of the product are you using? On what operating system?
Version: libmv-0.1-full_Win-x86-msvc2008
Operating System: Windows 7

Please provide any additional information below.

Original issue reported on code.google.com by kuru...@gmail.com on 4 Nov 2011 at 6:50

GoogleCodeExporter commented 9 years ago
Lowde kae bal, Bosudike try to do some coding on your own bosudike. 
Everytime u won't get spoon feed. Try to contribute something to project.
You always read and take the code but can't code yourself. Try to do some 
expertiments.
Finally if u can really contribute to this opensource it will be really nice.
Don't say that by taking code from website don't tell to your coleagues that 
you u did everything on your own bosudike....

Lowde ke bal

Original comment by vasukii...@yahoo.in on 14 Aug 2012 at 8:53