search

Ashyni / mpv-scripts

dynamic-crop.lua script for mpv player/lib.
MIT License
81 stars 4 forks source link

fix unexpected window resize behavior #13

Closed dyphire closed 1 year ago

dyphire commented 1 year ago

The new behavior of fix_windowed_behavior is still incorrect. When the mode is 1 or 3, no matter which value is used for this fix_windowed_behavior option before manually enabling the script, there should be not try avoids the default behavior of resize the window, which is not as expected.

Ashyni commented 1 year ago

Hello, it's hard to understand what you expect, but i think i got it, the geometry was updated at every osd-dimensions change which isn't necessary (probably old code i forgot to clean up). It wasn't an issue on my end, but i guess it can conflict with other script or option. Please test https://github.com/Ashyni/mpv-scripts/commit/5e41df37b2980995ec683e1009b49f5f67bee2e2 or the development branch. And next time open an issue, just in case there is more involved.

dyphire commented 1 year ago

Hello, it's hard to understand what you expect, but i think i got it, the geometry was updated at every osd-dimensions change which isn't necessary (probably old code i forgot to clean up). It wasn't an issue on my end, but i guess it can conflict with other script or option. Please test 5e41df3 or the development branch. And next time open an issue, just in case there is more involved.

Yes, this commit https://github.com/Ashyni/mpv-scripts/commit/5e41df37b2980995ec683e1009b49f5f67bee2e2 works for me.