search

Ashyni / mpv-scripts

dynamic-crop.lua script for mpv player/lib.
MIT License
81 stars 4 forks source link

feature-request: use new `--video-crop` for cropping operations #21

Closed dyphire closed 10 months ago

dyphire commented 10 months ago

Ref: https://github.com/mpv-player/mpv/pull/12246 This will optimize performance and fix #19

Note that this does not bring hwdec support.

Ashyni commented 10 months ago

Hello,

I started to do some test with video-crop, every crop change looks smoother than lavfi-crop, i will implement it properly, your PR miss multiple stuff, thanks for your contribution anyway.

Has for #19, this issue is related to cropdetect filter chain and not crop, so it doesn't change anything. And it's partially fixed with read_ahead_mode=0 (disable) in https://github.com/Ashyni/mpv-scripts/commit/72467235d3cafdc69b68c557397714ea90eefa0d and actually fully fixed with read_ahead_mode=1/2 (enable) by patch/ffmpeg/0001-avfilter-add-vf_dummysync.patch which need to be discussed with ffmpeg dev.

For now, the script remains limited to soft decoding or hwdec=*-copy.