Delete functionality added

Asiatik / Notezy

Notezy is an open sourced Note making webapp.

http://notezy.surge.sh

MIT License

11 stars 18 forks source link

Delete functionality added #5

Closed thakursaurabh1998 closed 6 years ago

thakursaurabh1998 commented 6 years ago

I have added the delete functionality as well as removed some imports which were not being used. @hkedia321 #4

thakursaurabh1998 commented 6 years ago

I can ignore the package-lock.json file but I have come across this Stackoverflow discussion @hkedia321

thakursaurabh1998 commented 6 years ago

hkedia321 commented 6 years ago

@thakursaurabh1998 Yes, it is generally recommended to commit it. But its also a matter of preference from project to project. Popular projects such as angular and material-ui doesn't have a package-lock.json file. Since it adds lots of noise to the PR, I would suggest to either add it to .gitignore or delete your package-lock.json file locally. We can have a separate PR to update it.

Also, please provide a demo surge link.

thakursaurabh1998 commented 6 years ago

I have removed the package-lock file, but i don't know how to create a demo surge link at the moment. I have created a build but it is not working currently. Can I give you a temporary link created by a tunnel?

thakursaurabh1998 commented 6 years ago

Temporary link

thakursaurabh1998 commented 6 years ago

Thank you @hkedia321 I will take care of it from next time. Can you add me to the organisation?

hkedia321 commented 6 years ago

@thakursaurabh1998 Sure, added. Welcome!