Allow users control on processed images

AsilHQ / Asil-ios

Asil iOS Browser

https://www.asil.co

Mozilla Public License 2.0

0 stars 0 forks source link

Allow users control on processed images #59

Open cemsertkaya opened 1 month ago

cemsertkaya commented 1 month ago

When an image is processed, we want to show a action list to users thru an overlay on the image. The overlay will be shown on hover.

A/C

On hover, the action button is shown (in the middle?) with action items
Actions can be take
- Show original image
- Report issue which should take to a page (or ideally on modal) for user to report issue. The report should send the original image & (when available processed image) link
- Hide the overlay - Sometime some sites implement their own overlays. So we want to give user option to hide our overlay. Once clicked, it should remove our overlay so other overlay(s) appear fine.
- This is implemented in iOS, Android, Extensions

Example:

Screenshot 2024-03-19 at 12 02 21 PM

cemsertkaya commented 1 month ago

https://github.com/AsilHQ/Asil-ios/assets/52299445/e198b703-7805-4503-bdee-dd1ee2085ab7

cemsertkaya commented 1 month ago

I added a button to the image and showed the original and processed URL for @thehungrycoder's request. We can discuss and improve this feature @nizamuddin

thehungrycoder commented 1 month ago

I was thinking something like this. Screenshot 2024-03-19 at 12 02 21 PM

cemsertkaya commented 1 month ago

@thehungrycoder how about we use our safegaze icon instead of using the "Safegaze" text when the hover is closed. For using less space.

++ I did not quite understand what is the difference between "Show Original" and "Hide this overlay"

cemsertkaya commented 1 month ago

Meantime I'm developing hover implementation

thehungrycoder commented 1 month ago

@thehungrycoder how about we use our safegaze icon instead of using the "Safegaze" text when the hover is closed. For using less space.

Sounds good to me. Button text was for example. Let's use logo.

++ I did not quite understand what is the difference between "Show Original" and "Hide this overlay"

That's actually a good question. we can remove remove "hide this overlay" item. basically not show it at all. Rather, remove the overlay when user clicks "show original". Let's do this for now.

cemsertkaya commented 1 month ago

@thehungrycoder what is the action I should implement for Report Issue button?

redirecting to a link or do you have a different idea?

thehungrycoder commented 1 month ago

Let's create a contact us form on our site and link it there

cemsertkaya commented 1 month ago

@thehungrycoder @nizamuddin these are the latest developments.

If you can give me a form link or something I can add to report issue action.

cemsertkaya commented 1 month ago

I'm sending a test flight for that feature let's test together on different images @thehungrycoder @nizamuddin

thehungrycoder commented 1 month ago

@cemsertkaya here a few things

The safegaze logo should not be always visibile. it should be visible on the hover only
the background does not look good. remove the background of the logo. also make the button little nicer
you can proceed without report issue until https://github.com/SafeGaze/web/issues/228 is completed. Once that's completed you can implement that.

cemsertkaya commented 1 month ago

Hi @thehungrycoder, I wrote you from whatsapp maybe you missed. Can we make a brief call about this issue?

thehungrycoder commented 1 month ago

Hi @thehungrycoder, I wrote you from whatsapp maybe you missed. Can we make a brief call about this issue?

Let's do