Closed AsimKhan2019 closed 2 years ago
Opening a new pull request
https://github.com/AsimKhan2019/Hello-World/blob/2dd30eaea30ca316bd1b8d4370d0c726e6efbd4d/README.md?plain=1#L1-L73 You didn't make any changes to your README. Kindly fix this as this is your project's documentation and having it written this way makes your project look unprofessional. This is part of the project requirements as well.
https://github.com/AsimKhan2019/Hello-World/blob/2dd30eaea30ca316bd1b8d4370d0c726e6efbd4d/.gitignore#L1-L2
You need to add the node_modules
folder to the .gitignore
file according to the project requirements.
In order to have a node_modules
folder in your root directory, you need to install linters locally, to do so please follow the instructions in this repo's README.
Kindly fix this.
According to the project requirements, this file should be ignored by git, kindly fix this.
.
[OPTIONAL] It is considered bad practice to use color names. I recommend you change these colors to their rgb
or hex
code equivalents.
Merge pull request #10 from AsimKhan2019/feature