search

AsimKhan2019 / Kanban_Board

0 stars 0 forks source link

Peer to peer code review #29

Open bienvenuushindi opened 2 years ago

bienvenuushindi commented 2 years ago

Highlights :bulb:

Great work so far. Your codebase looks cleaner and well modularize

Required Change :recycle:

I think It will be better if you create a global variable where you can store the part of your URL that doesn't change so that you avoid repeating yourself. You may have a hard time when it comes to updating your URL key since you have to look for the URL link everywhere in your code but having it stored in a variable will help you change it easily

https://github.com/AsimKhan2019/Kanban_Board/blob/a851879c775d48587abe2311683474563e4d07a5/src/modules/InvolvementAPI.js#L4-L6

AsimKhan2019 commented 2 years ago

@bienvenuushindi Thank you for this review, I will make amendments to the code.