search

Askannz / gaming-flightcheck

MIT License
8 stars 1 forks source link

ERROR : distribution detection : no distribution name found #2

Open FruityWelsh opened 5 years ago

FruityWelsh commented 5 years ago

https://pastebin.com/8t6b8z5f

Got:
ERROR : distribution detection : no distribution name found
on ubuntu 18.04

FruityWelsh commented 5 years ago

Would offloading this to https://pypi.org/project/distro/ be a good idea?

Askannz commented 5 years ago

Ah yes, that's a bug, thanks. You are probably missing hostnamectl or lsb_release. The program should have warned you about it, but it didn't because of the crash.

Would offloading this to https://pypi.org/project/distro/ be a good idea?

I would prefer not to rely on external python dependencies unless that's absolutely necessary. Ideally the program would work as a standalone, self-contained script that people can just download and run.

That said, the page you linked list a few additional methods for getting the distribution name. I'll try to implement them :slightly_smiling_face:

FruityWelsh commented 5 years ago

hostnamectl should have worked though (output was scrubed by me): Static hostname: [Personal Data] Icon name: computer-desktop Chassis: desktop Machine ID: [Personal Data] Boot ID: [Personal Data] Operating System: Ubuntu 18.04.2 LTS Kernel: Linux 5.0.15-steamvr-generic Architecture: x86-64

lsb_release gives me: No LSB modules are available.

Askannz commented 5 years ago

Sorry, didn't see your message. Does it still not work with the current master ?

FruityWelsh commented 5 years ago

correct