search

Askedio / laravel-soft-cascade

Cascade Delete & Restore when using Laravel SoftDeletes
https://medium.com/asked-io/cascading-softdeletes-with-laravel-5-a1a9335a5b4d
MIT License
705 stars 63 forks source link

add belongs to relation to soft cascade #68

Closed rybakk closed 6 years ago

rybakk commented 6 years ago

Fix belongsTo relations cascade soft delete

maguilar92 commented 6 years ago

@rybakk Can you create an integration test?

rybakk commented 6 years ago

Yes, i'm gonna do this.

maguilar92 commented 6 years ago

@rybakk Thank you!!!

rybakk commented 6 years ago

I failed to fix the error, I created the unit tests to trace the error.

maguilar92 commented 6 years ago

@gcphost I need you to active 5.5 and 5.6 branches in travis-ci.org to check that all work before merge pull request.

Thanks.

gcphost commented 6 years ago

@maguilar92 it's locked in the config: https://github.com/Askedio/laravel-soft-cascade/blob/master/.travis.yml#L18-L20

gcphost commented 6 years ago

Will code review shortly.

maguilar92 commented 6 years ago

@rybakk I'm going to reverse the pull request. BelongsTo relation is used for define the inverse of HasOne relationship. You must define the cascading in HasOne relationship.