search

Asnivor / MedLaunch

A Windows (.NET) Front-End for the Mednafen Emulator
http://medlaunch.asnitech.co.uk/
Other
36 stars 6 forks source link

Text jumping when cycling through games #175

Closed BParks21 closed 6 years ago

BParks21 commented 7 years ago

When clicking on multiple games in my library i see text jumping outside the boundaries of the right sidebar that displays the games info and boxart.

Asnivor commented 7 years ago

Yup, confirmed. I guess I need to add an auto-horizontal scrollbar around that text (the same as has been done with the 'game stats' box above.

Asnivor commented 7 years ago

Should now be fixed in the upcoming release (possibly tonight, maybe tomorrow morning)

BParks21 commented 6 years ago

Been patiently waiting for this release, really looking forward to it!

BParks21 commented 6 years ago

This doesn't seem fixed in latest stable release. Text keeps jumping to the right when clicking through my game list. It's like a quick flash of the boxes to the right of the game like Game Stats and below that. To reproduce it just quickly click on different games.

Asnivor commented 6 years ago

Hi.

I'm either struggling to reproduce this, or I am misunderstanding the actual problem. (or potentially both of these).

When clicking through games really fast I occasionally see the sidebar panel flicker (where its lazy-loading data in the background). Is this what you mean?

If not, perhaps you could use a free screenrecorder (like OBS studio) and post a really should video of what you are seeing?

Many thanks,

-Asni

BParks21 commented 6 years ago

I will record it. I know that it never happened a few releases back so it's definitely a bug.

On Sep 27, 2017 12:50 AM, "Asnivor" notifications@github.com wrote:

Hi.

I'm either struggling to reproduce this, or I am misunderstanding the actual problem. (or potentially both of these).

When clicking through games really fast I occasionally see the sidebar panel flicker (where its lazy-loading data in the background). Is this what you mean?

If not, perhaps you could use a free screenrecorder (like OBS studio) and post a really should video of what you are seeing?

Many thanks,

-Asni

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Asnivor/MedLaunch/issues/175#issuecomment-332408096, or mute the thread https://github.com/notifications/unsubscribe-auth/ALncliDgtEW2VORhOg676_4qJB3WqPOHks5smdP5gaJpZM4PDVr9 .

Asnivor commented 6 years ago

Cool. A few versions back when you clicked on a game you had to wait for the sidebar to load all its data before you could click on another game. This was changed to 'lazy load' the sidebar data and increase responsiveness. I'm guessing this bug is something to do with that.

Thanks

SteveBurgess commented 6 years ago

Is it the same as is happening in this gif?

https://gfycat.com/UnselfishAlarmedAfricanwildcat

BParks21 commented 6 years ago

Yes that weird jumping never use to haopen.

On Sep 27, 2017 2:09 PM, "SteveBurgess" notifications@github.com wrote:

Is it the same as is happening in this gif?

https://gfycat.com/UnselfishAlarmedAfricanwildcat

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Asnivor/MedLaunch/issues/175#issuecomment-332608323, or mute the thread https://github.com/notifications/unsubscribe-auth/ALnclnadZTXrE2Fd_g8imbhcRW8xqC3xks5smo9bgaJpZM4PDVr9 .

SteveBurgess commented 6 years ago

Here is a super slow mo version.

https://gfycat.com/opulentsnappygazelle

Looks like the details pane disappears temporarily causing the search bar etc. to run over. It happens so quickly it looks like the text is jumping about.

Asnivor commented 6 years ago

https://github.com/Asnivor/MedLaunch/blob/master/MedLaunch/Classes/VisualHandlers/GamesLibraryVisualHandler.cs#L42

That is being called first whenever the selected game changes. WPF auto-sizing shinanigans i imagine.

Asnivor commented 6 years ago

Fixed in PR #191 by @SteveBurgess

@WizLizard the fix is now available in the latest dev build if you want to try it? Not sure when the next production release will be:

https://ci.appveyor.com/project/Asnivor/medlaunch/build/ML-0.5.18.3-DEV-95/artifacts

BParks21 commented 6 years ago

Ok i tested. Seems mostly fixed but boxart still seems a bit jumpy now. Could just be me being picky.

Asnivor commented 6 years ago

Excellent.

Yeah, the boxart is probably always going to be jumpy to be honest. Its the time that takes it to load in.

The alternative is to not show the sidebar content at all until everything has loaded in. But that will take a lot of work. I'll make a note and see if it can be looked at in the future.