search

Asparagus15 / GaussianShader

code for GaussianShader: 3D Gaussian Splatting with Shading Functions for Reflective Surfaces
Other
288 stars 23 forks source link

Is delta_normal_loss correct ? #8

Closed gs14iitbbs closed 6 months ago

gs14iitbbs commented 9 months ago

I think in delta_normal_loss() function, it should be --> l = delta_normal.permute(1,2,0).reshape(-1,3).norm(dim=-1) @Asparagus15

https://github.com/Asparagus15/GaussianShader/blob/28e4f89198e19c0cabee82369118923d9bd41bba/utils/loss_utils.py#L116

Asparagus15 commented 9 months ago

Thanks for reminding, I have fixed it in the latest update.