chore: fix clippy lints and add some documentation

AspectUnk / russh-sftp

SFTP subsystem supported server and client for Russh

Apache License 2.0

64 stars 21 forks source link

chore: fix clippy lints and add some documentation #23

Closed simonsan closed 6 months ago

simonsan commented 8 months ago

Should be rebased on #22 first, so we have CI and see what is going on.

There are some issues:

unused async
possible truncation of values due to casting that should be looked at
documentation missing (added template with TODO)
some other stuff

AspectUnk commented 6 months ago

Sorry, but I can't merge this because I don't see the point in most of the changes to the settings and implementations. I'm completely satisfied with the standard lint and clippy settings. Also, adding Send to generic types with Into<String> is not required, since internally it is converted to String which has an automatic Send implementation.

You can make a PR without the aforementioned changes, leaving only the changed fmt and etc. and then I will merge it. Thank you