search

AspectUnk / russh-sftp

SFTP subsystem supported server and client for Russh
Apache License 2.0
64 stars 21 forks source link

Respond with EOF when finished listing directory #27

Closed girstenbrei closed 6 months ago

girstenbrei commented 6 months ago

Thank you for the SFTP library!

I started to use it and noticed while testing different clients (sftp on the command line, paramiko with Python) that listing a directory running the basic server example does only work for sftp, but not paramiko. This seems to be related to Paramiko expecting EOF to end a directory listing. This matches the recommendation of the v3 specification as well as the docs for this method in russh-sftp itself.

Therefore I propose to have the server example follow this recommendation. I tested this locally with sftp and paramiko, both seem to work fine with this.

Have a nice weekend, Christoph

AspectUnk commented 6 months ago

Thank you, it's amazing how obvious little things can be forgotten.