Closed kylemhall closed 2 hours ago
Okay - I lied - one more thing three more things.
- If you disable savings in Library savings, the Library savings page disappears from the sidebar, meaning you can't ever turn it back on unless you bookmarked the page/remember the URL.
All four previous fixes look good. After several hours of video game break, I am now finally done with the actual test part - documentation to follow in a bit. Only two things this time:
If you have mixed formats on a bib, Aspen will completely ignore that checkout/reading history entry for calculating library savings. Even if it was random (first or last item indexed), I think libraries might find that preferable to a default to $0, but I can never be too sure about that either lol. Ball is in your court on that one, of course.
eContent format tallies seem good for eBook, eAudiobook, and eComic, but I could not get Libby eMagazines to join the tally, even though they had a default value. More side effects of the Libby Rack stuff since you don't really "check out" the magazines in the same way anymore? Note that I only tested eContent formats with Libby (eBook, eAudio, eMag) and Palace Project (eBooks).
fixed, it only happened if cookie consent was off.
fixed, changed message to: Updated %1% historic cost savings that were previously 0.
We were only calculating the current value when all checkouts were viewed. Fixed so the current value is calculated whenever we show the message (based on cached checkouts if applicable).
Yep I had a bug in the loop counter
Getting these on Library Savings page:
Warning: Undefined array key "profile" in C:\web\aspen-discovery\tmp\smarty\compile\8f0e0d1d37533e45c9e1b3dd522645ecb8a277af_0.file.librarySavings.tpl.php on line 39
Warning: Attempt to read property "value" on null in C:\web\aspen-discovery\tmp\smarty\compile\8f0e0d1d37533e45c9e1b3dd522645ecb8a277af_0.file.librarySavings.tpl.php on line 39
Warning: Attempt to read property "enableCostSavings" on null in C:\web\aspen-discovery\tmp\smarty\compile\8f0e0d1d37533e45c9e1b3dd522645ecb8a277af_0.file.librarySavings.tpl.php on line 39
Warning: Undefined array key "profile" in C:\web\aspen-discovery\tmp\smarty\compile\8f0e0d1d37533e45c9e1b3dd522645ecb8a277af_0.file.librarySavings.tpl.php on line 41
Warning: Attempt to read property "value" on null in C:\web\aspen-discovery\tmp\smarty\compile\8f0e0d1d37533e45c9e1b3dd522645ecb8a277af_0.file.librarySavings.tpl.php on line 41
Warning: Attempt to read property "enableCostSavings" on null in C:\web\aspen-discovery\tmp\smarty\compile\8f0e0d1d37533e45c9e1b3dd522645ecb8a277af_0.file.librarySavings.tpl.php on line 41
Something minor but has confused me when trying to make the documentation a bit -- the success message for Recalculating zero cost savings is also Updated %1% historic cost savings and maybe it shouldn't be?
I'm not seeing Checked Out Title savings though they are enabled and showing fine in Reading history, but I accidentally checked them out in Koha from a library that technically doesn't have the cost savings enabled (yet). Should that matter? (The items are owned by and checked out to patrons at a library with cost savings on.)
When I try to generate a reading history for a patron that is just for the last year, even if my minimum amount of checkouts is greater than 0, it always generates 0 reading history items. I had to go two years to get anything.
Description
To display how much money a patron is saving by using the library.
Full specification here: Proposal for Library Savings for Patrons.pdf
Testing Notes
Permissions
Verify that there is a new permission:
Verify that the Administer Replacement Costs permission is already applied to opacAdmin users
Verify that the Administer Replacement Costs permission can be applied to and removed from other permission roles
Aspen Administration Configuration
Verify that there is a new Replacement Cost option in Aspen Administration in the Catalog / Grouped Works section with a user that has the appropriate Administer Replacement Costs permission.
Adding new replacement cost settings
Verify that clicking the Update Active Formats button loads any formats in the current catalog as individual format settings with a default value of $0.00.
Verify that reloading active formats preserves existing replacement cost and (if applicable) adds new formats with a default value of $0.00.
Modify replacement cost settings
Verify that using Edit on an individual format saves the entered replacement cost value.
Verify that the Batch Update Selected and Batch Update All options update the expected formats with the replacement cost value entered.
Verify that Recalculate Historic Cost Savings changes replacement cost values.
Verify that Recalculate Zero Cost Savings changes only default/$0 replacement cost values.
Enable/Disable cost savings feature
Verify that Enable Enable cost savings setting shows in Aspen Admin > Primary Configuration > Library systems > ILS/Account Integration and is unchecked by default.
Verify that the Cost Savings Enabled Explanation setting shows in Aspen Admin > Primary Configuration > Library systems > ILS/Account Integration and is populated with default text.
Patron Account
Feature Disabled
Scenario 1: Unlinked account user (Feature Enabled)
Verify that the Library savings option shows in the Patron account menu under Reading History.
Verify that Monthly and Yearly savings graphs show in Library savings.
Verify that the "You have saved" cost saving statement appears at the top of reading history results if the setting is enabled for the library.
Verify that the "You are saving" statement appears at the top of reading history results if the setting is enabled for the library.
Verify that clicking Don't Track Library Savings disables saving statements and hides monthly and yearly savings graphs.
Scenario 2: Linked account user (Feature Enabled)
Repeat all tests listed above for a user with linked accounts. When verifying "You are saving" values for a user with linked accounts, ensure that the total number at the top of Checkouts is a tally of both the primary and secondary user(s) checked out items. Verifying "You have saved" values should look the same as an unlinked account user -- their reading history should only show their individual reading history items and savings.