dzc34
commented
6 years ago Great ! Thanks @davidjr82 for your contribution!
new release (with your work): https://app.contrast-finder.org/?lang=es
1 missing translation: "Switch to spanish" (the title attribute in language menu) ---> fixed by #158
and some change in "All details about the contrast ratio" section ---> fixed by #158
I verified my work is based on
developbranchPurpose of this Pull Request?
Translate it to spanish (in fact it should be es_ES - European Spanish)
Where should the reviewer start its review?
File "webapp/src/main/resources/i18n/contrast-finder_utf8_es.properties" has been added.
How the PR could be tested?
Test the site using Spanish file language. Check everything works.
Any background context you want to provide?
This PR hasn't been tested in localhost, so hopefully it doesn't break anything. Afterwards, I will review the site in Spanish to check that everything has sense or change any translation if any concepto fits better.
What are the related issues?
No issue has been opened. Help offered in twitter.
Screenshots (if appropriate)
No needed.
(by the way, thank you very much for contributing to Contrast-Finder!) (It has been a pleasure. As I said, I think developers need to start adopting accesibility by default in our work, and I think we must support this kind of tools.)