search

Asqatasun / Contrast-Finder

Contrast-Finder finds correct color contrasts (background / foreground) for web accessibility (a11y, WCAG, RGAA). https://app.contrast-finder.org
GNU Affero General Public License v3.0
56 stars 18 forks source link

Add Korean translation #85

Closed miname closed 7 years ago

miname commented 7 years ago

I verified my work is based on develop branch

Purpose of this Pull Request?

To make Korean users happy. 👍

Where should the reviewer start its review?

A new file titled as "contrast-finder_utf8_ko.properties" added.

How the PR could be tested?

No breaking changes, I hope.

Any background context you want to provide?

There are two paragraphs(line no. 51 and 57) where its usage is unknown. So I just left it untouched. Could you tell me in what context the phrase being used?

mfaure commented 7 years ago

Wouaw, awesome! Great job @miname! Thank you very much. @dzc34 will surely integrate this in the next release.

dzc34 commented 7 years ago

@miname, thank you very much. Integrated this in the new release. https://app.contrast-finder.org/?lang=ko

dzc34 commented 7 years ago

There are two paragraphs(line no. 51 and 57) where its usage is unknown. So I just left it untouched. Could you tell me in what context the phrase being used?

see #88

dzc34 commented 7 years ago

88 is now fixed

and available in the last release https://forum.asqatasun.org/t/contrast-finder-new-release-v0-8-1-korean-translation/357