search

Asratum / KP_find

KP Find QGIS Plugin
GNU General Public License v2.0
6 stars 0 forks source link

Please consider merging your work #1

Closed pcav closed 4 years ago

pcav commented 4 years ago

Since it is closely related to other plugins, it would be appreciated if you could consider merging your work with those rather than creating a new one. Would you mind contacting original authors? We can as well discuss about this in the public dev list. Sorry for bothering, we are trying to limit the duplication of work, for the benefit of users, developers, and managers alike. Thanks.

Asratum commented 4 years ago

Hi Paolo,

I was thinking about doing that, but decided to go ahead with my own plugin for several reasons:

Let me know what you think, and if we should take our discussion to the public dev list.

pcav commented 4 years ago

I understand well your arguments. However, the advantages over the mid and long term of joining a larger group are certainly worth the while. May I ask before deciding to start a discussion on qgis-dev, and put original authors in cc? Thanks for understanding.

Asratum commented 4 years ago

Sure, will do that!

hamiltoncj commented 4 years ago

@pcav @Asratum I understand how it is often easier to have your own plugin, but I also think that similar functionality should be merged together. I have not taken a close look at your plugin, but from your description it looks very close to the Shape Tools Geodesic measurement layer which will measure a lines or polygons from a layer and place the values into a new attribute field. It may be that it would be trivial to make slight enhancements to satisfy the rest of your needs if it doesn't quite meet them.

I am not sure what the purpose of making a copy of a point layer with new attributes is for.

pcav commented 4 years ago

thanks @hamiltoncj , glad you agree here. @Asratum would you mind exploring this possibility? Cheers.

Asratum commented 4 years ago

@hamiltoncj I think you should probably take a closer look and than we can make a decision. Some points to consider:

This is what I mean by KP Find kind of being in the middle between Lat Lon Tools and Shape Tools - if merging, should I merge it with LatLon because of the interactive bit, or with Shape Tools because of the geodesics? In either case, there would be duplication of code between those two plugins.

hamiltoncj commented 4 years ago

@Asratum @pcav After looking at your plugin more I think you are right to spin off a new plugin. Your plugin is not a direction I am trying to take either Lat Lon Tools or Shape Tools.

Asratum commented 4 years ago

OK, thanks for taking a look and for your work on your plugins!

pcav commented 4 years ago

Then I believe it's OK to publish it. Thanks for the analysis & discussion!

Il 05/03/20 21:27, C Hamilton ha scritto:

@Asratum https://github.com/Asratum @pcav https://github.com/pcav After looking at your plugin more I think you are right to spin off a new plugin. Your plugin is not a direction I am trying to take either Lat Lon Tools or Shape Tools.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Asratum/KP_find/issues/1?email_source=notifications&email_token=AAFI5AUV43ECZFS4NFLWSPDRGADJPA5CNFSM4KWBYAQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEN6YZCA#issuecomment-595430536, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFI5ASR2QV36V5E25PX5X3RGADJPANCNFSM4KWBYAQQ.

-- Paolo Cavallini - www.faunalia.eu QGIS.ORG Chair: http://planet.qgis.org/planet/user/28/tag/qgis%20board/