Asratum / KP_find

KP Find QGIS Plugin
GNU General Public License v2.0
6 stars 0 forks source link

Please do not include external libs #2

Closed pcav closed 2 years ago

pcav commented 4 years ago

to avoid duplication of code, etc. Since geographiclib is of rather general use, it would be probably appropriate to include it in the installers instead.

Asratum commented 4 years ago

the library in question is already included in a plugin in the official repository, so I assumed it would be okay to include it in mine: https://github.com/NationalSecurityAgency/qgis-shapetools-plugin I agree, it would be great to integrate the library in qgis (if that's what you mean), but my technical expertise is not good enough to do that at the moment on my own

pcav commented 4 years ago

Thanks for pointing out. Ticket opened on the other plugin. Please open a ticket on OSGeo4W to ask including it. In principle it is not difficult, you might be able to do it, or otherwise find a way of supporting it. Thanks.

Asratum commented 4 years ago

OK, will open a ticket on OSGeo4W

Asratum commented 4 years ago

I see that the OSGeo4W ticket was closed (https://trac.osgeo.org/osgeo4w/ticket/621). When I see that it is present in the next version of QGIS, I will remove the external lib.

pcav commented 4 years ago

It should be included in the upcoming point release, please make sure this is the case.

On 17 February 2020 20:49:53 CET, Asratum notifications@github.com wrote:

I see that the OSGeo4W ticket was closed (https://trac.osgeo.org/osgeo4w/ticket/621). When I see that it is present in the next version of QGIS, I will remove the external lib.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/Asratum/KP_find/issues/2#issuecomment-587136256

-- Please excuse my brevity.

pcav commented 4 years ago

Once included, please remove the lib so it can be published.

Asratum commented 2 years ago

External library removed with version 3.1.0, now using the QGIS one