fix: ignore this - Githubissues

AssemblyScript / assemblyscript

A TypeScript-like language for WebAssembly.

https://www.assemblyscript.org

Apache License 2.0

16.82k stars 655 forks source link

fix: ignore this #2834

Closed CountBleck closed 6 months ago

CountBleck commented 6 months ago

This is a dummy commit to create a new release.

[x] I've read the contributing guidelines
[x] I've added my name and email to the NOTICE file

HerrCai0907 commented 6 months ago

Do you know why our release pipeline does not work?

HerrCai0907 commented 6 months ago

I found the reason, aspublish requires breaking / feat / fix prefix to identifier the version upgrade. Maybe we need to create an action and check the PR title to avoid this weird empty PR. WDYT?

CountBleck commented 6 months ago

@HerrCai0907 That would be nice, but if a PR only has one commit, the default commit title in the merge commit is based off of that commit's title, not the PR title (see #2826).

HerrCai0907 commented 6 months ago

@HerrCai0907 That would be nice, but if a PR only has one commit, the default commit title in the merge commit is based off of that commit's title, not the PR title (see #2826).

Yes. But we can switch the merge strategy in configuration page. I am not sure who has the access to setup it. Maybe it needs @dcodeIO or @MaxGraey

CountBleck commented 6 months ago

@HerrCai0907 that doesn't sound ideal...

HerrCai0907 commented 6 months ago

Configuration like this:

Why is it not ideal?

dcodeIO commented 6 months ago

Changed the setting to "Pull request title" as suggested

CountBleck commented 6 months ago

Why is it not ideal?

@HerrCai0907 Oh I misunderstood (I thought you meant switching away from squash merging). That's perfect!