AssemblyScript / binaryen.js

A buildbot for browser & Node.js builds of Binaryen, a compiler infrastructure and toolchain library for WebAssembly.
http://github.com/WebAssembly/binaryen
Apache License 2.0
355 stars 49 forks source link

Making types visible again to TypeScript compiler. #60

Closed ghadeeras closed 2 years ago

ghadeeras commented 2 years ago

Resolves #59

Note: As I do not have intimate knowledge of the internals of this project, this PR is meant only as a suggested solution, or at least to highlight what caused the above-mentioned issue.

I basically reverted a previous change in which a constant of the same shape as the module was exported instead of the module itself, which effectively made the type declarations private. I am not sure that change is needed anymore after reverting the exporting of binaryen as a Promise.

See issue #59 for the effect of the previous change.

dcodeIO commented 2 years ago

Thanks for fixing this :)