search

AssemblyScript / binaryen.js

A buildbot for browser & Node.js builds of Binaryen, a compiler infrastructure and toolchain library for WebAssembly.
http://github.com/WebAssembly/binaryen
Apache License 2.0
355 stars 49 forks source link

commonjs #63

Closed dvtate closed 4 months ago

dvtate commented 2 years ago

I have no idea when or why this package became an esm-only project but it should definitely offer both module systems or create a separate packages as converting my entire project over to esm has come with some new painpoints

dvtate commented 2 years ago

Also I feel like this is a more substantial breaking change an have no idea when it occured between v99.0.0 and v109.0.0... really I feel like this semver sysytem isn't right either

MaxGraey commented 2 years ago

Also I feel like this is a more substantial breaking change an have no idea when it occured between v99.0.0 and v109.0.0... really I feel like this semver sysytem isn't right either

This just wrapper of native binaryen and version synced with native's version.

dvtate commented 2 years ago

the native's version is not v109.0.0 it's version_109

MaxGraey commented 2 years ago

the native's version is not v109.0.0 it's version_109

That's right. They have the same major versions. I don't see any inconsistency here

dvtate commented 2 years ago

Just the 2 wasted subversions... Regardless, this is besides the point of breaking module compatibility. You can look at yargs for example of a package which supports both esm and commonjs

judehunter commented 2 years ago

I stumbled onto this as well. CommonJS builds should definitely be included...