AssessingSolar / unofficial-psm3-userguide

https://assessingsolar.github.io/unofficial-psm3-userguide
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Create page for the "23:00 UTC artifact" #7

Closed kandersolar closed 1 year ago

kandersolar commented 1 year ago

This addresses one of the items in #1:

The 23:00 UTC Tamb artifact in 5-minute data

The notebook is rather basic at the moment. Ideas for possible additions:

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

AdamRJensen commented 1 year ago

My only issue going through this was the last plot. Upon initial inspection, the white space at the top merely looks like an artifact from setting the y-limit too high. Though I realize this is not the case, but the white is due to the diverging colormap and that there is no change in this region. I played around with a few other colormaps, but nothing I found was better (since it needs to be diverging to make sense).

Perhaps adding a light grey background to the plot helps enhance the white bar at the top of each subplots:

fig, axes = plt.subplots(2, 2, sharex=True, sharey=True, facecolor='lightgrey')

image

kandersolar commented 1 year ago

Thanks for pointing out that issue. I thought about switching the plot to be in local time so that the white strip would be somewhere in the middle, but then went a different way altogether for summarizing the .diff() across a year of data (here it is in local standard time):

image

Separately, I've also extended the notebook along the lines at the top of this thread (irradiance is not affected by this artifact; 15- and 30-minute data have the same issue as 5-minute).