search

AssetSync / asset_sync

Synchronises Assets between Rails and S3
1.88k stars 346 forks source link

Use threads for uploads #393

Closed JanStevens closed 4 years ago

JanStevens commented 4 years ago

Original implementation from #284

Updated based on the comments, for us we saw our CI going from 12min to 3min

By default it's disabled (and using the old logic)

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 381

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/asset_sync/engine.rb 0 1 0.0%
<!-- Total: 13 14 92.86% -->
Files with Coverage Reduction New Missed Lines %
lib/asset_sync/engine.rb 1 0.0%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 376: 0.5%
Covered Lines: 8874
Relevant Lines: 13710
💛 - Coveralls
PikachuEXE commented 4 years ago

Thanks for PR Can you please update it so that it looks like other boolean config like include_manifest? YML support and stuff Also need test case

JanStevens commented 4 years ago

Ping small friendly reminder if you got the time :)

PikachuEXE commented 4 years ago

Oh ya new commits won't trigger a notification on GitHub usually Anyway will take a look tomorrow or later this week

PikachuEXE commented 4 years ago

And released in 2.9.0