Closed RickCSong closed 4 years ago
Totals | |
---|---|
Change from base Build 402: | 0.4% |
Covered Lines: | 374 |
Relevant Lines: | 576 |
Hey @RickCSong, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
Hey @RickCSong, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
Hey @RickCSong, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
This is really great feedback @PikachuEXE ! I've updated the PR accordingly -- great callout on using .close
.
I've also added tests since I believe we are generally happy with the direction of this change :)
@RickCSong You forgot to solve the conflict again lol
Sorry @PikachuEXE ! Done.
Released in 2.10.0
Before, asset_sync would create a separate thread for every asset that was uplaoded. When there are a large number of assets being uploaded, this could lead to processes crashing due to too many threads being created.
By limiting the number of threads, this speeds up performance while preventing crashes from resource starvation.
See: https://github.com/AssetSync/asset_sync/issues/395