Support `google_json_key_string` as an alternative to `google_json_key_location`

AssetSync / asset_sync

Synchronises Assets between Rails and S3

1.89k stars 346 forks source link

Support `google_json_key_string` as an alternative to `google_json_key_location` #407

Closed nwallace closed 3 years ago

nwallace commented 4 years ago

In some environments, (in my case, Kubernetes), it can be easier to store uncommitted secrets in the environment itself, rather than on disk. Fog itself supports being configured either way. I don't believe there's a reason this gem can't work the same way

PikachuEXE commented 4 years ago

Sorry I am on holiday Come back next week

PikachuEXE commented 3 years ago

I think it's fine but you have to create the PR and test it (manually) Automatic test is also required like what's done for GOOGLE_JSON_KEY_LOCATION

PikachuEXE commented 3 years ago

Should be fixed via #415