Fix get_non_fingerprinted with dashed filenames

AssetSync / asset_sync

Synchronises Assets between Rails and S3

1.89k stars 346 forks source link

Fix get_non_fingerprinted with dashed filenames #414

Closed cgriego closed 3 years ago

cgriego commented 3 years ago

upload_files uses get_non_fingerprinted to determine if any non-fingerprinted files need to be uploaded because there's a new fingerprinted file. It does this by determining that if assets/image-digest.png needs to be uploaded then assets/image.png should also be uploaded, if it exists. But it faultily would determine that if assets/great-image-digest.png needed to be uploaded then assets/great.png should be uploaded if it exists instead of assets/great-image.png.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 513

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 63.863%

Totals
Change from base Build 508:	0.0%
Covered Lines:	410
Relevant Lines:	642

💛 - Coveralls

PikachuEXE commented 3 years ago

Will try to review this week On vacation last week

PikachuEXE commented 3 years ago

Released in 2.13.1