search

Asshat-Gaming / rmp-rp-issues

Asshat Gaming RAGE Multiplayer: Roleplay Server Code - Public Issue Tracker
0 stars 0 forks source link

Research and add connection.end/connection.release/connection.destroy to all completed database connections #17

Closed SugarD-x closed 2 years ago

SugarD-x commented 3 years ago

Connection ending/releasing/destroying needs to be researched and added to all database connections for security, memory usage, and performance reasons.

SugarD-x commented 2 years ago

This has been added, however it seems to be breaking some scripts. This needs further testing and research.

SugarD-x commented 2 years ago

As mentioned here: https://github.com/mysqljs/mysql/issues/1081

JS/node.js don't handle connections the same way as other languages, (such as PHP), and require a different method for handling connection closures. Connection pooling may be required to resolve this, however implementing such in this design of a scripting system may prove complex, and is not yet fully understood in terms of how it could be done properly. Suggestions from others may be needed here.

SugarD-x commented 2 years ago

This has been completed.