search

AssistantNMS / App

📲 The Assistant app (for No Mans Sky) you know and love 💖
https://nmsassistant.com
GNU General Public License v3.0
25 stars 3 forks source link

🐛 Bug Report: Purged ribs have incorrect consume stats #258

Open Lenni009 opened 1 month ago

Lenni009 commented 1 month ago

📜 Describe the bug

Purged ribs say "restore 3% health" in the app, but only "2%" in game. Probably rounding error (always round down)

👟 To Reproduce

  1. Go to Purged Ribs
  2. See "will restore 3% health"
  3. Go to https://nomanssky.fandom.com/wiki/Purged_Ribs#Gallery
  4. Click on gallery image
  5. See "will restore 2% health"
  6. -> mismatch

👍 Expected behavior

App should match game

📱 Where did you find this problem?

Android, WebApp

🪵 Logs

No response

👀 Have you checked if this bug report has been created already?

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

None

Khaoz-Topsy commented 1 month ago

The consumable reward for Purged Ribs is DE_FOOD_HEALTH2 and it has the value of min 3 and max 3 in the REWARDTABLE.EXML image

But this is an older version, I haven't been able to get the latest REWARDTABLE.MBIN to decompile with the MBINCompiler, so when it is working again, these values might be correct. I will wait till then 😋

Lenni009 commented 1 month ago

The mismatch is still in the app (at least on the web) and I haven't seen any specific change in the mentioned PR (but that PR is big, so I might have missed something). The game files also haven't changed, so that would mean there is probably some multiplier somewhere.

Khaoz-Topsy commented 1 month ago

Ah thanks, I must have confused the issue id at some point