AssistantNMS / App

📲 The Assistant app (for No Mans Sky) you know and love 💖
https://nmsassistant.com
GNU General Public License v3.0
25 stars 3 forks source link

🚀 Feature request: Use proper data for upgrades #264

Open Lenni009 opened 1 month ago

Lenni009 commented 1 month ago

🔖 Describe the solution you'd like

Upgrades are currently a bit confusing. This probably stems from the fact they they can be in "Module" or "Upgrade" form. The "Modules" have the item data in the game files, while the "Upgrades" only have template data. This is already implemented with the Neutron Cannon upgrades, but not with other upgrades, for example Mining Beam.

My solution would be to combine these two:

This is primarily intended for the web app for now, but transferring this to mobile should be trivial, the generated data source is the same after all. I'm using the X-Class Mining Beam Upgrade as an example here, your script would hopefully handle everything on its own.

Here's a mockup for how it would look on the web Not too crazy, it's basically just the name, subtitle and description changed. grafik

Also note that the item now has dev details from the module item.

Implementing this would close #48 and #214.

🩹 Describe alternatives you've considered

No response

👀 Have you checked if this bug report has been created already?

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

None

Lenni009 commented 1 month ago

I expect this to also mess with URLs, so the API needs to be adjusted accordingly.

See https://github.com/AssistantNMS/WebApi/issues/1

Lenni009 commented 1 month ago

To add to this: Sentinel Exosuit Fragment and Sentinel Weapons Shard are duplicated in the app.

One of them has dev details, the other does not.

Maybe it would be good to keep them as separate items, with their respective name, icon, description, etc., but link to each other. So in the case of the Sentinel Exosuit Fragment, the module would have a link "Deploys into: Forbidden Exosuit Module", with a chip styling similar to how cooking and refining products are styled. The Forbidden Exosuit Module would have a link "Deployed from: Sentinel Exosuit Fragment".

As for the name of the Forbidden Exosuit Module (and other upgrades), use the subtitle. Another example would be "A-Class %NAME% Upgrade" (taken from the Subtitle in the PROCEDURALTECHNOLOGYTABLE), which is deployed from "Neutron Cannon Module" (taken from the Name in the PRODUCTTABLE).

That way you would still have two items, both with proper data, and linked to each other. Then there should hopefully be no more confusion and no lost data.