search

Assisted-Mindfulness / naive-bayes

Naive Bayes works by looking at a training set and making a guess based on that set.
MIT License
40 stars 2 forks source link

PHPStan + Tokenizer improvements #1

Closed bdelespierre closed 2 years ago

bdelespierre commented 2 years ago

Hey, cool lib. I want to use it. Here are some suggested changes:

  1. 1a1a1f0 added PHPStan as a dependency, configured to level 9
  2. cb4d38d fixed some small typing issues to make PHPstan happy
  3. cb4d38d removed a bunch phpdoc comments that weren't really needed
  4. 175a701 narrowed the Classifier API (not all methods are useful I think)
  5. 175a701 allow for custom tokenizer

What do you think?

bdelespierre commented 2 years ago

I forgot to add before force-push :man_facepalming:

It's done @tabuna