search

Assisted-Mindfulness / naive-bayes

Naive Bayes works by looking at a training set and making a guess based on that set.
MIT License
40 stars 2 forks source link

Make extendable? #3

Open ConnectGrid opened 3 months ago

ConnectGrid commented 3 months ago

Thank you for your hard work on this project. One of the strengths of a library like this is to integrate into other software. However, when class properties are given a visibility of private, that reduces the extendability, as those properties are not visible to the extending class.

Is there a reason that the properties were made private? Could they be made protected instead to facilitate extending? Could functionality be moved to a Trait, with the Classifier simply using that trait?

These are just some ideas. If you are open to pull requests, I'd be happy to submit some of them for consideration.

tabuna commented 3 months ago

I'm glad the project has been useful for you. I'll gladly accept your Pull Request to change the properties to protected. I'm always open to new ideas and willing to consider any suggestions or requests.