search

AssistoLab / DropDown

A Material Design drop down for iOS
MIT License
2.44k stars 625 forks source link

Swift 4.2 support #191

Closed chlumik closed 6 years ago

chlumik commented 6 years ago

Simple change to support Swift 4.2

lawgimenez commented 6 years ago

Hope this gets merged soon.

Mordil commented 6 years ago

This will resolve #190

kevin-hirsch commented 6 years ago

Hello @chlumik 👋

Thanks a lot for this PR 🙏 It's now merged. I've created a new version 2.3.3 available via CocoaPods and Carthage 🚀

chlumik commented 6 years ago

@kevin-hirsch You're welcome.

22Round commented 6 years ago

@kevin-hirsch I have updated with cocoapods latest version 2.3.3 and have this errors

screen shot 2018-09-24 at 17 16 36

any thoughts?

saormart commented 6 years ago

@22Round, have you tried to configure the framework for the 4.2 version? screen shot 2018-09-24 at 9 29 59 am

kevin-hirsch commented 6 years ago

Hello @22Round 👋

I forgot to update the .swift-version file that CocoaPods uses to determine the Swift version that the project uses (which still was 4.0)

It should now work if you try using the latest version DropDown v2.3.4 🎉

Thanks for noticing 🙏

22Round commented 6 years ago

@kevin-hirsch @saormart Thanks, I updated pod and it compiles only one warning remained, please fix it ;)

screen shot 2018-09-25 at 11 58 24
kevin-hirsch commented 6 years ago

Hey @22Round,

It's done and available in version 2.3.5 😉