Open mrubin opened 8 years ago
Hello @mrubin,
If I understand correctly, you have an app that only supports landscape mode but the KVNProgress
loader does rotate in portait mode?
That's indeed a problem.
I think a good solution would be to have a new UIInterfaceOrientationMask supportedOrientations
property for KVNProgressConfiguration
that would be used when instantiating the KVNRotationViewController
. Then the KVNRotationViewController
could use it in the supportedInterfaceOrientations
method.
I will work on that along with the Carthage support ;)
It doesn't rotate all the way, but it looks like it starts rotating and then rotates back to where it was... so it "flickers".
If it will soon be possible to use
KVNProgress
via Carthage (meaning it will be compiled into a static library and then imported into your app), it becomes impossible to change the values ofKVNRotationViewController
- you cannot subclass it either becauseKVNProgress
directly instantiates it via:(I suppose you could swizzle it?)
Would it be possible to somehow make use of the
Configuration
to makeKVNRotationViewController
configurable beyond compile time? For example, for my app I need to use:Perhaps
KVNRotationViewController
could be given a pointer toKVNProgressConfiguration
?