search

AstarNetwork / Astar

The dApp hub for blockchains of the future
https://astar.network/
GNU General Public License v3.0
739 stars 349 forks source link

remove genesis state print #1235

Closed ermalkaleci closed 4 months ago

ermalkaleci commented 5 months ago

This genesis state generated is incorrect. If we don't need it then better remove it closes #1234

Dinonard commented 5 months ago

Dumb question - why is it incorrect?

ermalkaleci commented 5 months ago

Dumb question - why is it incorrect?

it's using state_version 1

ashutoshvarma commented 5 months ago

@ermalkaleci How about hardcoding the state_verison here to V0, all parachains state_version was 0 in genesis anyways?

ermalkaleci commented 5 months ago

@ermalkaleci How about hardcoding the state_verison here to V0, all parachains state_version was 0 in genesis anyways

Then it will be wrong for local and dev

ermalkaleci commented 5 months ago

@Dinonard didn't have gpg setup before so I can't merge this. Can you do it?

Dinonard commented 5 months ago

@Dinonard didn't have gpg setup before so I can't merge this. Can you do it?

Uh, no, they have to be signed. I don't have admin rights for the repo.

Can you force-push the signed commits?

ermalkaleci commented 5 months ago

@Dinonard didn't have gpg setup before so I can't merge this. Can you do it?

Uh, no, they have to be signed. I don't have admin rights for the repo.

Can you force-push the signed commits?

force-push works

github-actions[bot] commented 5 months ago

Code Coverage

Package Line Rate Branch Rate Health
chain-extensions/pallet-assets/src 56% 0% ➖
pallets/dapp-staking-migration/src 0% 0% ❌
precompiles/assets-erc20/src 81% 0% ✔
pallets/dapp-staking-v3/src 92% 0% ✔
precompiles/xvm/src 75% 0% ➖
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0% ❌
pallets/astar-xcm-benchmarks/src 88% 0% ✔
pallets/dynamic-evm-base-fee/src 92% 0% ✔
pallets/collator-selection/src 92% 0% ✔
pallets/astar-xcm-benchmarks/src/generic 100% 0% ✔
precompiles/unified-accounts/src 100% 0% ✔
chain-extensions/xvm/src 0% 0% ❌
pallets/static-price-provider/src 52% 0% ➖
chain-extensions/types/assets/src 0% 0% ❌
pallets/inflation/src 83% 0% ✔
chain-extensions/unified-accounts/src 0% 0% ❌
precompiles/xcm/src 73% 0% ➖
pallets/dapp-staking-v3/src/test 0% 0% ❌
precompiles/sr25519/src 64% 0% ➖
chain-extensions/types/unified-accounts/src 0% 0% ❌
pallets/dapp-staking-v3/src/benchmarking 99% 0% ✔
pallets/ethereum-checked/src 79% 0% ➖
pallets/price-aggregator/src 72% 0% ➖
precompiles/dapp-staking-v3/src 90% 0% ✔
primitives/src/xcm 64% 0% ➖
pallets/oracle-benchmarks/src 0% 0% ❌
chain-extensions/types/xvm/src 0% 0% ❌
precompiles/dapp-staking-v3/src/test 0% 0% ❌
pallets/unified-accounts/src 86% 0% ✔
precompiles/dispatch-lockdrop/src 86% 0% ✔
pallets/xvm/src 54% 0% ➖
precompiles/substrate-ecdsa/src 74% 0% ➖
pallets/astar-xcm-benchmarks/src/fungible 100% 0% ✔
primitives/src 61% 0% ➖
pallets/xc-asset-config/src 64% 0% ➖
Summary 78% (3599 / 4632) 0% (0 / 0) ➖

Minimum allowed line rate is 50%