search

AstarNetwork / Astar

The dApp hub for blockchains of the future
https://astar.network/
GNU General Public License v3.0
732 stars 200 forks source link

burn extrinsic integration #1244

Closed Dinonard closed 1 month ago

Dinonard commented 1 month ago

Pull Request Summary

Integrates burn extrinsic into all runtimes, using a custom fork of pallet-balances (link).

ashutoshvarma commented 1 month ago

@Dinonard just a suggestion to add the dummy keep_alive bool in extrinsic signature to make sure it's not a breaking change when we switch to upstream version

Dinonard commented 1 month ago

LGTM! but what about astar & shiden weights?

Local and Shibuya use custom pallet-balances weights since we have integrated account unification into them. For Astar & Shibuya it's not the case, so we can just reuse plain weights from the pallet crate itself.

Dinonard commented 1 month ago

@Dinonard just a suggestion to add the dummy keep_alive bool in extrinsic signature to make sure it's not a breaking change when we switch to upstream version

Sure, why not!

github-actions[bot] commented 1 month ago

Code Coverage

Package Line Rate Branch Rate Health
pallets/astar-xcm-benchmarks/src/generic 100% 0% ✔
primitives/src/xcm 64% 0% ➖
precompiles/unified-accounts/src 100% 0% ✔
chain-extensions/types/unified-accounts/src 0% 0% ❌
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0% ❌
pallets/static-price-provider/src 52% 0% ➖
pallets/unified-accounts/src 86% 0% ✔
chain-extensions/unified-accounts/src 0% 0% ❌
pallets/dynamic-evm-base-fee/src 92% 0% ✔
precompiles/assets-erc20/src 81% 0% ✔
pallets/xvm/src 54% 0% ➖
pallets/oracle-benchmarks/src 0% 0% ❌
precompiles/substrate-ecdsa/src 74% 0% ➖
primitives/src 61% 0% ➖
precompiles/xcm/src 73% 0% ➖
chain-extensions/types/xvm/src 0% 0% ❌
pallets/dapp-staking-v3/src 92% 0% ✔
pallets/inflation/src 83% 0% ✔
precompiles/dapp-staking-v3/src/test 0% 0% ❌
chain-extensions/types/assets/src 0% 0% ❌
pallets/astar-xcm-benchmarks/src 88% 0% ✔
precompiles/xvm/src 75% 0% ➖
pallets/xc-asset-config/src 64% 0% ➖
pallets/ethereum-checked/src 79% 0% ➖
pallets/astar-xcm-benchmarks/src/fungible 100% 0% ✔
precompiles/dispatch-lockdrop/src 86% 0% ✔
pallets/dapp-staking-v3/src/test 0% 0% ❌
precompiles/sr25519/src 64% 0% ➖
pallets/collator-selection/src 92% 0% ✔
chain-extensions/pallet-assets/src 56% 0% ➖
pallets/dapp-staking-v3/src/benchmarking 99% 0% ✔
chain-extensions/xvm/src 0% 0% ❌
precompiles/dapp-staking-v3/src 90% 0% ✔
pallets/dapp-staking-migration/src 0% 0% ❌
pallets/price-aggregator/src 72% 0% ➖
Summary 78% (3599 / 4632) 0% (0 / 0) ➖

Minimum allowed line rate is 50%