AstarNetwork / Astar

The dApp hub for blockchains of the future
https://astar.network/
GNU General Public License v3.0
732 stars 200 forks source link

introduce new field in struct and update genesis file used explicitly in DEV #1248

Closed yuriechan closed 1 month ago

yuriechan commented 1 month ago

Pull Request Summary

Check list

To Reviewers

Fixes #1188

ermalkaleci commented 1 month ago

This is a storage value. Why don't you use chopsticks or sudo to override storage. What is the use case of this?

Dinonard commented 1 month ago

@ermalkaleci it's related to this issue: https://github.com/AstarNetwork/Astar/issues/1188

Dinonard commented 1 month ago

@yuriechan please make sure to test cargo test --features try-runtime,runtime-benchmarks to ensure no tests are broken.

yuriechan commented 1 month ago

@yuriechan please make sure to test cargo test --features try-runtime,runtime-benchmarks to ensure no tests are broken.

I ran the command locally, and it seems that all test cases are passing.