Closed ermalkaleci closed 2 weeks ago
Package | Line Rate | Branch Rate | Health |
---|---|---|---|
pallets/astar-xcm-benchmarks/src | 88% | 0% | ✔ |
precompiles/dapp-staking-v3/src | 90% | 0% | ✔ |
primitives/src/xcm | 64% | 0% | ➖ |
chain-extensions/xvm/src | 0% | 0% | ❌ |
pallets/static-price-provider/src | 52% | 0% | ➖ |
pallets/inflation/src | 83% | 0% | ✔ |
pallets/astar-xcm-benchmarks/src/fungible | 100% | 0% | ✔ |
pallets/astar-xcm-benchmarks/src/generic | 100% | 0% | ✔ |
pallets/collator-selection/src | 92% | 0% | ✔ |
precompiles/dispatch-lockdrop/src | 86% | 0% | ✔ |
chain-extensions/types/unified-accounts/src | 0% | 0% | ❌ |
precompiles/sr25519/src | 64% | 0% | ➖ |
pallets/dynamic-evm-base-fee/src | 92% | 0% | ✔ |
primitives/src | 61% | 0% | ➖ |
pallets/dapp-staking-v3/src/test | 0% | 0% | ❌ |
pallets/dapp-staking-v3/rpc/runtime-api/src | 0% | 0% | ❌ |
pallets/ethereum-checked/src | 79% | 0% | ➖ |
precompiles/substrate-ecdsa/src | 74% | 0% | ➖ |
pallets/xc-asset-config/src | 64% | 0% | ➖ |
chain-extensions/types/assets/src | 0% | 0% | ❌ |
chain-extensions/types/xvm/src | 0% | 0% | ❌ |
precompiles/unified-accounts/src | 100% | 0% | ✔ |
chain-extensions/unified-accounts/src | 0% | 0% | ❌ |
precompiles/xvm/src | 75% | 0% | ➖ |
pallets/dapp-staking-v3/src | 92% | 0% | ✔ |
precompiles/assets-erc20/src | 81% | 0% | ✔ |
chain-extensions/pallet-assets/src | 56% | 0% | ➖ |
pallets/dapp-staking-v3/src/benchmarking | 98% | 0% | ✔ |
pallets/xvm/src | 54% | 0% | ➖ |
precompiles/xcm/src | 73% | 0% | ➖ |
pallets/dapp-staking-migration/src | 0% | 0% | ❌ |
precompiles/dapp-staking-v3/src/test | 0% | 0% | ❌ |
pallets/unified-accounts/src | 86% | 0% | ✔ |
pallets/oracle-benchmarks/src | 0% | 0% | ❌ |
pallets/price-aggregator/src | 72% | 0% | ➖ |
Summary | 78% (3600 / 4635) | 0% (0 / 0) | ➖ |
Minimum allowed line rate is 50%
1 more code comment, otherwise LGTM
For the PR summary, thanks for not leaving it empty but unfortunately it's not informative at all. It doesn't help with code review, so it would be the same even if it was empty.
I'd suggest to summarize the changes you do, especially for PRs such as these where lots of code is moved or deleted. That would make review easier, and would help set the tone for what to focus on.
E.g.:
- removed duplicated
start_node_impl
by using feature flag internally instead on the function level- ...
how that I am looking at "Files changed" there are a lot of changes. I will update to explain everything in more details
#[cfg(feature = "evm-tracing")]
for local service so did that. All featured related code move into a singlestart_node
method. Although this is not possible forstart_node_impl
but I was able to remove duplicated forstart_astar_node, start_shiden_node, start_shibuya_node
.build_import_queue
is renamed tobuild_import_queue_fallback
used by Shiden (see code comments).build_import_queue
will create aura block importer to be used for Astar and Shibuya.